Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of issues with this #145

Open
mwkcoding opened this issue Feb 19, 2019 · 0 comments
Open

A bunch of issues with this #145

mwkcoding opened this issue Feb 19, 2019 · 0 comments

Comments

@mwkcoding
Copy link

I've found a bunch of issues with this package so far.

The config gives you a "notifier" namespace where you'd assume you can change the namespace and use your own notifier. If you search the entire package, that config is NEVER used.

Also the package breaks if you don't SPECIFICALLY use a model for your notifications which is, in my opinion, not very user-friendly.

The package also needs a revision on the documentation since it just very lightly goes over some of the functionality.

On another note, I'm having issues with registering my own event listener on the RaiseHealthIssue. I've registered it in the EventServiceProvider and it doesn't register at all. (Laravel 5.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant