Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative paths for Template(Raw)GroupDirectory #93

Closed
wants to merge 1 commit into from
Closed

Relative paths for Template(Raw)GroupDirectory #93

wants to merge 1 commit into from

Conversation

twoi
Copy link

@twoi twoi commented Feb 2, 2018 •
edited

new TemplateRawDictionary("dir") does not work and new Uri() throws exception, although Path.GetFullPath() returns true.

With this change, both relative and absolute directory paths can be used. Btw, TemplateGroupFile already uses GetFullPath(). This fixes #73

@twoi
Relative paths for Template(Raw)GroupDirectory
2354a77 
`new TemplateRawDictionary("dir")` does not work and `new Uri()` throws exception, although `Path.GetFullPath()` returns true.

With this change, both relative and absolute directory paths can be used. Btw, `TemplateGroupFile` already uses `GetFullPath()`.
@twoi twoi mentioned this pull request Feb 2, 2018
Open
@sharwell
Copy link
Member

sharwell commented Feb 2, 2018

TemplateGroupFile uses GetFullPath starting with #87, but the URI is constructed in a slightly different manner. It would be good to add some tests covering this behavior (which fail prior to the change, but then pass afterwards). The Antlr4.Test.StringTemplate project is tested in both Windows and Linux environments automatically, so that would be the place to add the tests.

@twoi
Copy link
Author

twoi commented Feb 5, 2018

Pulling this PR because it is already addressed by #87

@twoi twoi closed this Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"new TemplateGroupFile(fileName)" only works with full file path
2 participants
@twoi @sharwell