Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video.js plugin does not use the provided iceServers #6292

Open
wheelbarrow777 opened this issue Apr 23, 2024 · 1 comment
Open

Video.js plugin does not use the provided iceServers #6292

wheelbarrow777 opened this issue Apr 23, 2024 · 1 comment

Comments

@wheelbarrow777
Copy link

Short description

In https://github.com/ant-media/videojs-webrtc-plugin, the iceServers provided in the player.src() call is not used in the NPM package.

player.src({
  src: 'ws://localhost:5080/LiveApp/stream1.webrtc',
  iceServers: '[ { "urls": "stun:stun1.l.google.com:19302" } ]'
});

In https://www.npmjs.com/package/@antmedia/videojs-webrtc-plugin?activeTab=code, navigate to /dist/videojs-webrtc-plugin.js. At line 3858, the RTCPeerConnection config used is this.peerconnection_config. this.peerconnection_config is defined once and never changed at line 2869.

Correct behavior would be to change line 3858 to this.remotePeerConnection[streamId] = new RTCPeerConnection(this.pcConfig);, as this.pcConfig is the configuration parsed from the src.

@mekya
Copy link
Contributor

mekya commented May 6, 2024

Hi @wheelbarrow777,

Thank you for the report. We've put it to the backlog.

If you want us to make this a priority, please reach out to contact@antmedia.io or continue your discussion with the support channel.

Cheers
Oguz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants