New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web3ConfigProvider should inherit the props from the parent Web3ConfigProvider #417
Comments
<Web3ConfigProvider locale={{
ConnectButton: {
connect: 'Connect'
}
}}>
<Web3ConfigProvider extendsContextFromParent>
<ConnectButton />
</Web3ConfigProvider>
</Web3ConfigProvider> Add a |
Why add the extendsContextFromParent property, shouldn't providers naturally support automatic nested configuration merging |
There are many attributes related to blockchain involved, and I'm concerned that merging by default could cause confusion. But after giving it more thought, perhaps not merging could lead to even more confusion. So, let's go with the default merge. However, perhaps we can add an 涉及到很多区块链相关的属性,担心默认合并会带来误导。不过仔细想了想,也许不合并会带来更多误导。 那还是默认合并吧,不过或许可以加一个 |
I totally agree with you, props extendsContextFromParent is confusing. |
Dealing with the following common situations:
The text was updated successfully, but these errors were encountered: