feat: add toggle callback to Ellipsis component #6576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6576.surge.sh |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6576 +/- ##
=======================================
Coverage 92.34% 92.34%
=======================================
Files 318 318
Lines 6910 6912 +2
Branches 1729 1731 +2
=======================================
+ Hits 6381 6383 +2
Misses 493 493
Partials 36 36 ☔ View full report in Codecov by Sentry. |
|
这里我只是先发出来讨论一下，感觉用toggle这个名字不太好
|
zombieJ
reviewed
Mar 21, 2024
| @@ -21,6 +21,10 @@ export type EllipsisProps = { | |||
| stopPropagationForActionButtons?: PropagationEvent[] | |||
| onContentClick?: (e: React.MouseEvent<HTMLDivElement, MouseEvent>) => void | |||
| defaultExpanded?: boolean | |||
| toggle?: ( | |||
There was a problem hiding this comment.
Could we use onEllipsis instead. It's same as the antd API:
https://ant.design/components/typography-cn#api
There was a problem hiding this comment.
Indeed, the design of onEllipsis in antd is more reasonable. The correct logic is to trigger onEllipsis based on whether the text is ellipsized or not. I'll continue working on it.
|
Why close? |
1 similar comment
|
Why close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6570