Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: Invalid DOM property fill-rule. Did you mean fillRule? #603

Open
sabreu-teknorix opened this issue Sep 27, 2023 · 8 comments · May be fixed by #604
Open

Warning: Invalid DOM property fill-rule. Did you mean fillRule? #603

sabreu-teknorix opened this issue Sep 27, 2023 · 8 comments · May be fixed by #604

Comments

@sabreu-teknorix
Copy link

I am getting this warning in the console
image
localpath added a commit to localpath/ant-design-icons that referenced this issue Oct 8, 2023
@localpath
Update close-circle.svg Fixes ant-design#603
4c1fe1f 
Fixes ant-design#603 Invalid DOM props `fill-rule`
@localpath localpath linked a pull request Oct 8, 2023 that will close this issue
Open
@localpath
Copy link

@sabreu-teknorix submitted a PR against this invalid prop

localpath added a commit to localpath/ant-design-icons that referenced this issue Dec 12, 2023
@localpath
Update close-circle.svg Fixes ant-design#603
882cbee 
Fixes ant-design#603 Invalid DOM props `fill-rule`
@linround
Copy link

When will it be fixed?

@vryzhova
Copy link

vryzhova commented Feb 7, 2024

@localpath Will it be fixed in version "@ant-design/icons": "4.0.0"?) And when?)

@RobbertWolfs
Copy link

its also on other icons..

image

@afc163
Copy link
Member

afc163 commented Feb 21, 2024

@RobbertWolfs Could you provide a codesandbox reproduce?

@localpath
Copy link

@afc163 I opened a PR already for this fix. You can see here the SVG is incorrectly implemented not using JSX prop syntax, rather a mix of JSX and HTML syntax

https://github.com/ant-design/ant-design-icons/pull/604/files#diff-0fc7bc4d89c25c35eb2e9992006a736c290c47643fca45f5153c057778986c27

@afc163
Copy link
Member

afc163 commented Feb 23, 2024

@localpath Could you provide a codesandbox reproduce?

@RobbertWolfs
Copy link

@afc163 As you can see we just have a basic react + vite setup with ant design installed and when you open the console you see the same issue

https://codesandbox.io/p/devbox/fervent-minsky-skhhlk

image

And as you can see its on multiple icons

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update close-circle.svg Fixes #603 localpath/ant-design-icons
6 participants
@afc163 @RobbertWolfs @vryzhova @linround @localpath @sabreu-teknorix