Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify labels for "default" AWX template #1820

Open
3 tasks done
hagaram opened this issue Apr 11, 2024 · 2 comments
Open
3 tasks done

Add ability to specify labels for "default" AWX template #1820

hagaram opened this issue Apr 11, 2024 · 2 comments

Comments

@hagaram
Copy link

hagaram commented Apr 11, 2024

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX Operator is open source software provided for free and that I might not receive a timely response.

Feature Summary

At the moment there is possibility to specify additional_labels for child objects of AWX object, which si neat, but if someone want to use this functionality with default helm awx template, there is no way to specify labels for the AWX object itself (https://github.com/ansible/awx-operator/blob/devel/.helm/starter/templates/awx-deploy.yaml).
Or at least I dont know how, so I've used kustomize to patch the object. This could be easily avoided.

If no labels are specified for AWX object, then additional_labels are not being applied.

Please add ability to specify labels, when using default AWX deploy template.

@fosterseth
Copy link
Member

thanks for opening this ticket.

would it just be a matter of adding a label here https://github.com/fosterseth/awx-operator/blob/368f78624470bf10d4c7b48a7a955242ae76c537/.helm/starter/templates/awx-deploy.yaml#L6
? then additional_labels will take effect?

@hagaram
Copy link
Author

hagaram commented May 21, 2024

@fosterseth Thank you for commenting.
Yes, thats exactly it. This is simple kustomize patch I use, which gets the job done.

apiVersion: awx.ansible.com/v1beta1
kind: AWX
metadata:
  name: awx
  labels:
    external-dns.alpha.kubernetes.io/managed: true

So adding value, which would get passed to template metadata.labels should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants