Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying a custom registry for all sources #1811

Open
3 tasks done
daneov opened this issue Apr 7, 2024 · 3 comments
Open
3 tasks done

Support specifying a custom registry for all sources #1811

daneov opened this issue Apr 7, 2024 · 3 comments
Labels
community type:enhancement New feature or request

Comments

@daneov
Copy link

daneov commented Apr 7, 2024

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX Operator is open source software provided for free and that I might not receive a timely response.

Feature Summary

Idea

Is there a 'global' field that I can use to override all references to quay.io?

Use-case:

In a corporate environment we make use of Artifactory as a pull-through-cache (for a variety of reasons).
We want to make sure AWX uses this same mechanism, but it's been quite a journey on how to achieve this.

Reasoning

So far I've found the following required fields when attempting to do this:

redis_image: docker.private.registry.com/redis
redis_image_version: latest # -- required, but it shouldn't be imo: #1441 
control_plane_ee_image: docker.private.registry.com/ansible/awx-ee:24.1.0
init_container_image: docker.private.registry.com/ansible/awx-ee
init_container_image_version: 24.1.0 # -- required, but it shouldn't be imo: #1441 
image: docker.private.registry.com/ansible/awx
image_version: 24.1.0 # -- required, but it shouldn't be imo: #1441 
ee_images:
  - name: Cached-EE
    image: docker.private.registry.com/ansible/awx-ee
postgres_image: docker.private.registry.com/sclorg/postgresql-15-c9s
postgres_image_version: latest

Aside from #1441, this leaves me with the following questions:

  1. Are there any I missed?
  2. Would it be possible to define a global 'registry' somehow, to ensure I don't miss anything?
@kurokobo
Copy link
Contributor

kurokobo commented Apr 7, 2024

@daneov
Hi,

Are there any I missed?

In addition to your list, there is init_projects_container_image for AWX CR.
Also. for Operator itself, you should replace registry.example.com/ansible/awx-operator and gcr.io/kubebuilder/kube-rbac-proxy with your mirror by kustomize or any way.

Would it be possible to define a global 'registry' somehow, to ensure I don't miss anything?

AFAIK currentry there is no such option to override container registry for all images. However, for your purposes, I think it would be more appropriate to specify your pull-through-cache as registry mirrors for the container runtime of your Kubernetes cluster (e.g. containerd), rather than having Operator provide this functionality.

@daneov
Copy link
Author

daneov commented Apr 7, 2024

Those images are indeed covered through Kustomize, I forgot to copy those.

re your last suggestion: I didn't even think of that, that'd be a great option indeed! Thanks for the pointer :)

@RobinSegura
Copy link

Indeed last suggestion is a good one ! except for us quay is not yet fully supported by our jfrog proxy.
As a big IT Team a request would put days for artifactory behavior to be changed ... It would be much simpler for our team to change all registry mirror with a single endpoint (as current proxy behaviour can be fixed on our side just by removing "quay.io" in image header) but we have to do it once per image
Anyway thanks for the heads-up ;)

@fosterseth fosterseth added type:enhancement New feature or request and removed needs_triage labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community type:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants