Convert Byte Size Unit Measure

[marlonpatrick]

Like statistics representing TIME, I suggest that statistics that symbolize BYTES SIZE can be converted based on a unit of measure.

So, code like this would be simplified:

The code would look like this:

In this way, all information about bytes would be available in the most varied units of measurement without the need to rewrite code when any of these units of measurement were needed.

All other features would need to be adjusted: gauges, charts, accumulators etc to add a unit of measurement to be used.

[dvayanu]

This is an interesting idea. However, if I understand you correctly it would mean to change the signature of net.anotheria.moskito.core.producers.IStats#getValueByNameAsString, right?
This will lead to signature change of nearly all Stats Implementations... I assume we will be able to help us out with a generic method in abstract stats however.

Than we will need to add the current byte size to the UI, so we can switch the byte representation in the UI, right?

This is an interesting idea, but we have to discuss the implications, cause the changes will be many... We are not refusing it, just staying that we need to think and talk about it a little bit longer.

I am not sure which positive effects you are expecting besides the implementation of the above methods?

[marlonpatrick]

In fact it is a very big change. It does not only change the Stats but also Gauges, Accumulators, Charts would have to be adjusted to add this option.

The positive effect is that the end user can view the information in the way that best suits them without having to rewrite code.

Another day I had to override a Stat class to add a conversion to MB, because getValueByNameAsString returned only the value in bytes. The view of the information in bytes format was very bad due to the very large size (GB).

From a technical point of view, the implementation gets simpler too, I do not need to be doing hardcoded conversions. In short, it's the same effect as TimeUnit.

Anyway, I think it would be a big improvement on the Moskito.