Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove @anonklub/proof package #302

Open
0xisk opened this issue Jan 29, 2024 · 2 comments
Open

fix: remove @anonklub/proof package #302

0xisk opened this issue Jan 29, 2024 · 2 comments
Assignees

Comments

@0xisk
Copy link
Collaborator

0xisk commented Jan 29, 2024

          I see you are still using the `ProofRequest` object in the ui.

@anonklub/proof was meant as a package to make server side proof.
As we now do client side proofs I don't see a need for that separate package anymore.

Shoudn;t we move ProofRequest either to the new spartan worker package or define it directly in the ui (ui/src/lib)

Moreover this should be a redefined ProofRequest class.
The original class has some methods to submit and getResult from the proving server... this we definitely don't need anymore.

Originally posted by @sripwoud in #295 (comment)

@0xisk
Copy link
Collaborator Author

0xisk commented Jan 29, 2024

#295 (comment)

@0xisk
Copy link
Collaborator Author

0xisk commented Jan 29, 2024

#295 (comment)

@sripwoud sripwoud changed the title fix: removing @anonklub/proof package fix: remove @anonklub/proof package Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant