-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept Merkle Root in addition to array of addresses #219
Comments
Hi @orkunkilic |
Probably I won't be able to do in following 2-3 weeks. After then I can take a look if you haven't already started :) What do you think about the possible solution? Should we create new endpoints for just submitting root, or should we change everything from leaves[] to root only? |
Nice idea @orkunkilic! I think there's no major advantage to sending the leaves - your way is more succinct, and (in some sense) more privacy preserving. If you get to it before me, I think changing everything to root only is fine. |
Is your feature request related to a problem? Please describe.
Instead of giving the anonimity set, user can construct merkle tree locally and send the root to the API.
Describe the solution you'd like
Extend ProofRequest to ProofRequestWithRoot. Accept merkle root in the constructor. Skip building merkle tree in the server if type is ProofRequestWithRoot.
Describe alternatives you've considered
Completely remove array of addresses and implement root only class.
The text was updated successfully, but these errors were encountered: