Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Merkle Root in addition to array of addresses #219

Open
orkunkilic opened this issue Jul 7, 2023 · 3 comments
Open

Accept Merkle Root in addition to array of addresses #219

orkunkilic opened this issue Jul 7, 2023 · 3 comments

Comments

@orkunkilic
Copy link

orkunkilic commented Jul 7, 2023

Is your feature request related to a problem? Please describe.
Instead of giving the anonimity set, user can construct merkle tree locally and send the root to the API.

Describe the solution you'd like
Extend ProofRequest to ProofRequestWithRoot. Accept merkle root in the constructor. Skip building merkle tree in the server if type is ProofRequestWithRoot.

Describe alternatives you've considered
Completely remove array of addresses and implement root only class.

@sripwoud
Copy link
Collaborator

Hi @orkunkilic
I think what you're suggesting makes sense!
Do you feel like submitting an implementation a PR?
Otherwise @BlakeMScurr or myself could work on it.

@orkunkilic
Copy link
Author

Hi @orkunkilic I think what you're suggesting makes sense! Do you feel like submitting an implementation a PR? Otherwise @BlakeMScurr or myself could work on it.

Probably I won't be able to do in following 2-3 weeks. After then I can take a look if you haven't already started :)

What do you think about the possible solution? Should we create new endpoints for just submitting root, or should we change everything from leaves[] to root only?

@BlakeMScurr
Copy link
Collaborator

Nice idea @orkunkilic! I think there's no major advantage to sending the leaves - your way is more succinct, and (in some sense) more privacy preserving. If you get to it before me, I think changing everything to root only is fine.

@sripwoud sripwoud closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2023
@sripwoud sripwoud reopened this Aug 9, 2023
@sripwoud sripwoud closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
@sripwoud sripwoud reopened this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants