Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API change/update #5

Open
ankitaggarwal011 opened this issue Aug 12, 2016 · 4 comments
Open

API change/update #5

ankitaggarwal011 opened this issue Aug 12, 2016 · 4 comments

Comments

@ankitaggarwal011
Copy link
Owner

Currently, the API provides a way to give the location of the input file for processing and requires the desired location of the output. This inhibits the flexibility of the library to some extent.

Another way would require the API to deal directly with the image matrices rather than the location and the onus of I/O would fall on the developer. However, completely eliminating the current API would pose a problem to people who are looking for plug-n-play solution. Thus, it might be better to support both the forms of API.

Any suggestions are welcome. Thanks!

@sahildua2305
Copy link

@ankitaggarwal011 Do you intend to take input file blob from the user and then process it?

@ankitaggarwal011
Copy link
Owner Author

Hi @sahildua2305, I was thinking about including the api such that the I/O operations are taken care by the user, and the api will take an input image Numpy matrix and provide the processed result as a Numpy output image matrix.

One advantage of constraining the type of input as Numpy image matrix would be easy validation of input, however, it maybe wise to include the other types (blob, array) of the input image. A certain restriction has to be made on the type of input. What do you think about this?

Thanks for helping out. Appreciate it!

@bradstimpson
Copy link

Hi @ankitaggarwal011 I can help out here. Any objections if I jump in?

@ankitaggarwal011
Copy link
Owner Author

@bradstimpson, please go ahead. Your contributions are most welcome. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants