Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asking for clarification regarding forks and licensing #97

Open
drcmda opened this issue Mar 10, 2018 · 3 comments
Open

Asking for clarification regarding forks and licensing #97

drcmda opened this issue Mar 10, 2018 · 3 comments

Comments

@drcmda
Copy link
Contributor

drcmda commented Mar 10, 2018

I am currently transforming animated into something that i believe would make it easier to use, as well as adding new primitives for stuff that's missing like mount/unmount transitions. The changes are too radical for a PR so i started a fork:

https://github.com/drcmda/react-spring

At first i started out just wrapping it but got stuck and had to make small changes to the source, but to solve some deeper issues i would have to rework some of the internal logic.

Now i am a little nervous about the licensing. Before i waste lots of time on this for nothing, could anyone tell me if that's generally okay or not? I don't want money or anything really, just a nice animation lib for react.

Another question: i've started to refactor the code into esm for smaller packages (if rollup encounters any cjs it will deoptimize). Lebab seems to have stripped the licensing hints from the source curiously. If i place the licenses into the same directory, would that be fine? https://github.com/drcmda/react-spring/tree/master/src/animated

@browniefed
Copy link
Member

Unsure, but @vjeux is the creator.
Technically this was from the react-native source which has now been changed to MIT.
I don't think you're the first to fork and make changes.

@vjeux
Copy link
Collaborator

vjeux commented Mar 10, 2018

We should change the license here to be MIT as well. Is anyone willing to send a PR?

As for modifying the code, go for it! This is why we are open sourcing it in the first place. I want to see cool stuff like this happen :)

@drcmda
Copy link
Contributor Author

drcmda commented Mar 10, 2018

Thank you both for clarifying and for your awesome work and support!

@drcmda drcmda mentioned this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants