Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two mistakes #1

Open
jiweihuang opened this issue Aug 19, 2018 · 5 comments
Open

two mistakes #1

jiweihuang opened this issue Aug 19, 2018 · 5 comments

Comments

@jiweihuang
Copy link

The Class "NewtonStep" has two mistakes.
1.LinearSolver<DMatrixRMaj, DMatrixRMaj> qrSolver = LinearSolverFactory_DDRM.qr(dummyJacobian.numRows, dummyJacobian.numCols);
2.LinearSolver<DMatrixRMaj, DMatrixRMaj> cDecomposition = LinearSolverFactory_DDRM.chol(dummyJacobian.numRows);

Lack "DMatrixRMaj" generic parameter in raw Class

@staffanu
Copy link

LinearSolver only takes one type parameter in version 0.31 of ejml. In 0.34 (the latest version), LinearSolver has been renamed to LinearSolverDense, which still only takes one type parameter.

@jiweihuang
Copy link
Author

@staffanu thank you.

@jiweihuang
Copy link
Author

What new features can we expect to see in 2.0 and when will it be released?

@xiaohuangyu
Copy link

I also found this mistake
I solve this by add "import org.ejml.interfaces.linsol.LinearSolverDense;" and change "LinearSolver" to "LinearSolverDense"

@xiaohuangyu
Copy link

my version is 0.35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants