Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'oauth:profile' broadcast parameter for the example in the readme. #94

Open
robin-maxxton opened this issue Aug 17, 2015 · 2 comments
Labels

Comments

@robin-maxxton
Copy link

Hi,

First I'd like to say, this library has been very helpful so far in my authentication process.
Though I ran into some problems while trying to figure out where to get the profile details.
In the readme it said that you can use the 'oauth:profile' broadcast to achieve this.
So I implemented it, but instead of getting the profile I got information about the broadcast event.

Looking at the angular code I managed to find that the broadcast listener should have a second parameter, like this...

$scope.$on('oauth:profile', function(event, profile) {
    console.log('User profile data retrieved: ', profile);
});

Do correct me if I'm wrong, but I guess the example in the readme should contain two parameters instead of one. Or maybe soms code broke/changed.

@rtucker88
Copy link

I'm having the same issue as you @robin-maxxton. It looks like the event parameter was missing in the documentation.

@m00s
Copy link
Member

m00s commented Aug 17, 2015

You're right guys, the param profile is missing. Gonna add it, thanks!

@m00s m00s added the docs label Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants