Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

sidenav: does not automatically handle entering hidden state on resize #4595

Open
josephperrott opened this issue Sep 11, 2015 · 5 comments · May be fixed by #11581
Open

sidenav: does not automatically handle entering hidden state on resize #4595

josephperrott opened this issue Sep 11, 2015 · 5 comments · May be fixed by #11581
Assignees
@Splaktar
Labels
for: internal contributor The team will address this issue and community PRs are not requested. g3: reported The issue was reported by an internal or external product team. has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. type: bug
Milestone
- Backlog

Comments

@josephperrott
Copy link
Member

josephperrott commented Sep 11, 2015 •
edited by Splaktar

If a sidenav component is in an open/active state when a resize occurs and the resize causes the sidenav to go be hidden (for example hide-gt-sm is applied), I would expect the nav handle itself needing to enter a closed/nonactive state. Additionally, you can request to toggle the sidenav into an active state while it is hidden.

Both can be replicated here: http://codepen.io/josephperrott/pen/jbbpEq

Reproducables

Resize:
Open the page and size the window small enough for the sidenav to be available, toggle it open and then resize the page large enough for the sidenav to be hidden. The backdrop remains present, it then requires a click anywhere on the page for it to "close".

Toggle:
Open the page large enough that the sidenav cannot be displayed, then click the toggle sidenav button. The sidenav stays hidden, but the backdrop appears.
@jelbourn jelbourn added the g3: reported The issue was reported by an internal or external product team. label Sep 11, 2015
@ThomasBurleson ThomasBurleson added this to the 1.0-rc4 milestone Nov 5, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc5, 1.0-rc6 Nov 25, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc6, 1.0-rc7 Dec 3, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc7, 1.0-rc8 Dec 13, 2015
devversion added a commit to devversion/material that referenced this issue Dec 28, 2015
@devversion
feat(sidenav): track sidenav vissibilty and enter / leave backdrop if…
e5a9ea2 
… needed.

- Revert scope value if sidenav is shown.
- Throttle Resize Events

Fixes angular#4595
devversion added a commit to devversion/material that referenced this issue Dec 28, 2015
@devversion
feat(sidenav): track sidenav vissibilty and enter / leave backdrop if…
b20bdf3 
… needed.

- Revert scope value if sidenav is shown.
- Throttle Resize Events

Fixes angular#4595
@devversion devversion mentioned this issue Dec 28, 2015
Closed
devversion added a commit to devversion/material that referenced this issue Jan 1, 2016
@devversion
feat(sidenav): track sidenav vissibilty and enter / leave backdrop if…
b89b094 
… needed.

- Revert scope value if sidenav is shown.
- Throttle Resize Events

Fixes angular#4595
devversion added a commit to devversion/material that referenced this issue Jan 1, 2016
@devversion
feat(sidenav): track sidenav vissibilty and enter / leave backdrop if…
950216f 
… needed.

- Revert scope value if sidenav is shown.
- Throttle Resize Events

Fixes angular#4595
devversion added a commit to devversion/material that referenced this issue Jan 2, 2016
@devversion
feat(sidenav): track sidenav vissibilty and enter / leave backdrop if…
a180423 
… needed.

- Revert scope value if sidenav is shown.
- Throttle Resize Events

Fixes angular#4595
devversion added a commit to devversion/material that referenced this issue Jan 5, 2016
@devversion
feat(sidenav): track sidenav vissibilty and enter / leave backdrop if…
fcfff73 
… needed.

- Revert scope value if sidenav is shown.
- Throttle Resize Events

Fixes angular#4595
devversion added a commit to devversion/material that referenced this issue Jan 5, 2016
@devversion
feat(sidenav): track sidenav vissibilty and enter / leave backdrop if…
b2d0548 
… needed.

- Revert scope value if sidenav is shown.
- Throttle Resize Events

Fixes angular#4595
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc8, 1.1.0 Jan 5, 2016
@marosoft marosoft linked a pull request Jan 7, 2019 that will close this issue
Open
3 tasks
@marosoft
Copy link
Contributor

marosoft commented Jan 7, 2019

Updated CodePens:

@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue and removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Jan 8, 2019
@Splaktar Splaktar modified the milestones: 1.1.13, 1.1.14 Feb 10, 2019
@Splaktar Splaktar modified the milestones: 1.1.14, g3: sync Feb 15, 2019
@jelbourn jelbourn added P3: important Important issues that really should be fixed when possible. and removed P2: required Issues that must be fixed. labels Feb 22, 2019
@jelbourn jelbourn removed this from the g3: sync milestone Feb 22, 2019
@Splaktar Splaktar removed the g3: sync label Feb 26, 2019
@Splaktar Splaktar added this to the 1.1.21 milestone May 30, 2019
@Splaktar Splaktar modified the milestones: 1.1.21, 1.1.22 Aug 15, 2019
@Splaktar Splaktar modified the milestones: 1.1.22, 1.1.23 Oct 22, 2019
@Splaktar Splaktar modified the milestones: 1.1.23, 1.2.1 May 6, 2020
@Splaktar Splaktar modified the milestones: 1.2.1, 1.1.23 May 15, 2020
marosoft added a commit to marosoft/material that referenced this issue May 18, 2020
@marosoft
fix(sidenav): allow to hide side nav depending on the media query
dc4b8c4 
Current behavior is not correct

Fixes angular#4595
@Splaktar Splaktar modified the milestones: 1.1.23, 1.2.1 Jun 8, 2020
@Splaktar Splaktar modified the milestones: 1.2.1, 1.2.2 Sep 14, 2020
@Splaktar Splaktar modified the milestones: 1.2.2, - Backlog Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
for: internal contributor The team will address this issue and community PRs are not requested. g3: reported The issue was reported by an internal or external product team. has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. type: bug
Projects
None yet
Milestone
- Backlog
Development

Successfully merging a pull request may close this issue.

fix(sidenav): allow to hide side nav depending on the media query marosoft/material
6 participants
@ThomasBurleson @jelbourn @opoupeney @Splaktar @marosoft @josephperrott