Support secrets #36
Closed
Support secrets #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stolen from mysql Dockerfile, this change allows to read secrets from files
log and error fixes
fix function name
Encapsulate env setup
|
Hi, sorry I lost track of this. Since this is adding a lot of new complexity I will not merge it without having a proper unit test coverage for the backup and restore scripts. For the forseeable future I am going to leave wordpress-backup like it is to keep it simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this fork from @moracabanas where changes have been made to support reading the passwords from files (to allow for docker secret files to be used) Would you consider integrating these changes? It would close #35