Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency with Dagger and android library #288

Open
apurcaroiu opened this issue Oct 14, 2018 · 2 comments
Open

Dependency with Dagger and android library #288

apurcaroiu opened this issue Oct 14, 2018 · 2 comments

Comments

@apurcaroiu
Copy link

Hi,

I am working on a multi module project and I have used as a starting point this example, which helped a lot.

I am little bit stuck on this use case that I encountered:

  • Based on this clean architecture example, let's say I need another library android module which will handle payments with google play.
    It provides the entire billing provider integration and I decided to build it as a library as it will be referenced from other modules as well.
  • Once a purchase is being made I would need to update my wallet amount remote which is part of the data layer currently. So my payment library will have a reference to it.

The issue I am struggling with is that from the payment library I need to provide to the data layer API call an instance of the data store factory. Since I already have the data store factory injected as a singleton in the app module Application Component, I am not sure if I can or should expose it to the library or I need to handle a new instance managed from within the library and not use Dagger for this specific use case and repository.

Thanks for any suggestions!

@rajondj
Copy link

rajondj commented Oct 22, 2018

Dutch bangla bank joypurhat bangladesh. MD.ASHIKUR RAHMAN KHAN

@mishkaowner
Copy link

@apurcaroiu Uncle Bob clearly stated in this video, that you DONT want to inject anything into the Interactors (UseCase) period. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants