Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why features are inside 'app' module? #88

Open
RaggaJungler opened this issue Feb 22, 2020 · 2 comments
Open

Why features are inside 'app' module? #88

RaggaJungler opened this issue Feb 22, 2020 · 2 comments

Comments

@RaggaJungler
Copy link

I've read article and definitely support an idea of modularization.
Looking at the sample app I was wondering why don't move login and movies features into separate modules?
From my point of view it makes intents about modularization even clearer. Could you @android10, please, share your thoughts about it? Which flaws do you see in such approach?

Thanks.

@Zhuinden
Copy link

Because distributed monolith pattern increases complexity compared to having them in app module.

If you have 30-40 screens, 1 module is totally OK. In fact that way you don't need to mess around with duplicate resources in different modules and the like.

@RaggaJungler
Copy link
Author

@Zhuinden Could you explain why you think it's distributed monolith?
As for me it's more similar to microservices.

  1. I can reuse the same module inside different app.
  2. I can delete feature quite easily, just remove the module with this feature.

The only problem I can imagine is navigation. We can have a "main router" inside app module but this approach might not work starting from some scale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants