Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JetStream] Movie card titles are no longer horizontally constraint. #144

Open
dheineman opened this issue Dec 12, 2023 · 2 comments
Open

Comments

@dheineman
Copy link

In the recent pull request #142 the explicit width was removed from the modifier on the StandardCardLayout in the common/Moviesrow.kt file. This will cause the card to horizontally expand as needed to place the title of the item on the screen.

It is generally not noticeable in the sample as all the movie titles in movies.json are small enough but as the screenshot below shows longer titles will cause issues.

Screenshot_20231212_113257

@vighnesh153
Copy link
Contributor

vighnesh153 commented Dec 20, 2023

The title parameter in the cards accepts a composable as value. It is the responsibility of the card's consumer to clip off the extra text which might overflow. Additionally, users can also choose to append the text with an ellipsis.

@dheineman
Copy link
Author

Hey vighnesh, I opened the issue because i noticed it broke in the JetStream sample/demo application which itself is a consumer of the card. The MoviesRowItemText in the sample also uses overflow = TextOverflow.Ellipsis however this does not prevent the above from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants