Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose sample for CredentialManager #76

Open
yschimke opened this issue Apr 24, 2024 · 4 comments
Open

Compose sample for CredentialManager #76

yschimke opened this issue Apr 24, 2024 · 4 comments

Comments

@yschimke
Copy link

yschimke commented Apr 24, 2024

Adapting the sample for compose instead of fragments seems complex. I've done this before, but also made mistakes, so a compose sample would help the adoption.

I guess Compose + MAD, such as ViewModels, which complicate where you hoist auth logic and state.

@yschimke
Copy link
Author

Found https://github.com/Dashlane/android-passkey-example

Which I have no affiliation with, but is quite helpful.

@niharika2810
Copy link
Contributor

Hi We are working on this, you will get this by next month. The code is in review phase

There's a rough branch which has atleast the Compose and MAD (we are working on a refined MAD practices and clean version), please check glitch_me_sample branch

@yschimke
Copy link
Author

Thanks, great news.

Do you want any feedback on it?

@niharika2810
Copy link
Contributor

Hey, are you asking about current branch or the one which we are refining. Once we upload that code on main branch (somewhere in May), please feel free to share the feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants