Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchestrator sometimes runs all the instances of a parameterized test in the same process #2132

Open
PhilGlass opened this issue Jan 31, 2024 · 0 comments · May be fixed by #2133
Open

Orchestrator sometimes runs all the instances of a parameterized test in the same process #2132

PhilGlass opened this issue Jan 31, 2024 · 0 comments · May be fixed by #2133

Comments

@PhilGlass
Copy link

Description

Orchestrator has a fast path that skips test discovery if the test target is a single method:

android-test/runner/android_test_orchestrator/java/androidx/test/orchestrator/AndroidTestOrchestrator.java

Lines 259 to 262 in dd62f39

if (isSingleMethodTest(classArg)) {
Log.i(TAG, String.format("Single test parameter %s, skipping test collection", classArg));
callbackLogic.addTest(classArg);
runFinished();

This doesn't work for parameterized tests, since even a single method target may expand to any number of parameterized test instances.

Steps to Reproduce

Run a parameterized test method through test orchestrator. They will all run in the same process. You can verify this by logging the PID.

Expected Results

Each instance of the parameterized test runs in its own process.

Actual Results

All of the instances of the parameterized test run in the same process.
@PhilGlass PhilGlass linked a pull request Jan 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Orchestrator's single method fast path PhilGlass/android-test
1 participant
@PhilGlass