Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: improve error message when Espresso Intent matching fails due to mismatched Intent data #2112

Open
stkent opened this issue Jan 21, 2024 · 0 comments

Comments

@stkent
Copy link

stkent commented Jan 21, 2024

When Espresso Intent-matching fails to find a matching intent, it prints an error message:

"Found unverified intents.\n\nUnverified intents:%s\n\nRecorded intents:%s",
joinOnDash(unverifiedIntents), joinOnDash(recordedIntents)));

that includes string representations of all expected Intents and all recorded Intents.

Currently, this error message obfuscates the data associated with each Intent, because ResolvedIntentImpl::toString:

"%s handling packages:[%s]", super.toString(), getPossibleResolutionPackages()));

relies on Intent::toString rather than Intent::toInsecureString.

This makes debugging difficult if the reason for the Intent matching failure is a discrepancy in Intent data. Ideally, ResolvedIntentImpl::toString would use Intent::toInsecureString rather than Intent::toString, but I don't know how feasible that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant