Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug: tags in --keep-tags are removed #92

Open
akrasnov-drv opened this issue Jul 8, 2020 · 2 comments
Open

Possible bug: tags in --keep-tags are removed #92

akrasnov-drv opened this issue Jul 8, 2020 · 2 comments

Comments

@akrasnov-drv
Copy link

akrasnov-drv commented Jul 8, 2020

Hi,
Have an issue keeping old tags that are specified in --keep-tags
Here is my command:
docker run --rm anoxis/registry-cli -r http://registry:5000 --keep-by-hours 7300 --dry-run -i ubuntu --keep-tags 18.04 16.04
and here what I get

Will delete tag: 16.04 timestamp: 2017-11-04T09:45:35.219223981Z
Will delete tag: 18.04-2019-08-27 timestamp: 2019-08-27T13:07:39.539391663Z

I'd expect to keep both "newer" images and also 16.04 and 18.04 tags.
Please advise what is wrong in my command, otherwise please fix.
I believe all keep options should have priority over all delete options.

@akrasnov-drv
Copy link
Author

Yes, it's definitely a bug. I've tested it without "extra" options:
docker run --rm anoxis/registry-cli -r http://registry:5000 -d --dry-run --keep-tags 16.04
and still

Getting digest for tag 16.04
Keep digest sha256:88a0478aaf41fa07dfbd788f12dc160b13a4cadf041714828e097ab503e8b037 for tag 16.04
  tag: 16.04
  deleting tag 16.04

it maybe keeps blob but removes tag.

@akrasnov-drv
Copy link
Author

Looks like the bug is addressed in #85 but not merged since Dec, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant