Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo images on sponsor page #11

Open
mbourque opened this issue Jun 3, 2012 · 1 comment
Open

Logo images on sponsor page #11

mbourque opened this issue Jun 3, 2012 · 1 comment

Comments

@mbourque
Copy link
Contributor

mbourque commented Jun 3, 2012

It is going to be really hard to manage sponsor images with the current model using an image URL under the current design.

Problems:

  • Sponsors will provide us URLs, but will be all different shapes and widths
  • When displayed on the sponsor page, they don't fit and format as expected since the size is crucial
  • To fix the size and format, one will need to download the image and tweak it to work. Then upload again to another location and reference the URL.

It would be better to add an upload capability on the add sponsor page, that automatically resizes the image for the user. I've done this before on another project, and used a great plugin that takes care of this.

A few easy work arounds may be to specify the required image dimensions in help text on the add sponsor page. Or to you inline styles css to size the image x&y on the image tag of the sponsor listing page.

@andrewcurioso
Copy link
Owner

Note: as a stop gap I have updated the CSS to have a maximum width and height but since that won't work in order browsers we need a better solution. See: c191d6a

The design assumption was that logos would be uploaded in the webroot of the main app so the manager would have full control over the image sizes already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants