Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise support #24

Open
kahluagenie opened this issue Jan 27, 2016 · 4 comments
Open

Promise support #24

kahluagenie opened this issue Jan 27, 2016 · 4 comments

Comments

@kahluagenie
Copy link

Currently this easily works with Bluebird.promisifyAll(require('spotify-node-applescript')), but I think it would be fantastic if the library supported promises out of the box.

@markstickley
Copy link

Seconded. I'm currently wrapping all callback functions in my code to give promise functionality!

@matthewnitschke
Copy link

I have created a fork which supports Promises. You can find it here.

Unless you guys think otherwise, I don't think I will create a pull request for it because the changes remove callback functions, making it not backwards compatible.

@lucasbento
Copy link

@matthewnitschke: awesome, can you add it to npm so others can use it easily? can be under spotify-node-applescript-promise name.

@matthewnitschke
Copy link

@lucasbento just added it. Can be downloaded via

npm install spotify-node-applescript-promise 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants