Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crash in callback performAccessibilityAction #28

Open
quaych opened this issue Dec 28, 2020 · 1 comment
Open

App crash in callback performAccessibilityAction #28

quaych opened this issue Dec 28, 2020 · 1 comment

Comments

@quaych
Copy link

quaych commented Dec 28, 2020

Hi @andrefrsousa ,

Thank you for publishing lib SuperBottomSheet, this lib help our project a lot.
However, Firebase Crashlytics report a crash as below:

Fatal Exception: java.lang.IllegalArgumentException
Parameter specified as non-null is null: method kotlin.d0.d.l.g, parameter args

com.andrefrsousa.superbottomsheet.SuperBottomSheetDialog$wrapInBottomSheet$2.performAccessibilityAction (SuperBottomSheetDialog.java:7)
androidx.core.view.AccessibilityDelegateCompat$AccessibilityDelegateAdapter.performAccessibilityAction (AccessibilityDelegateCompat.java:126)
android.view.View.performAccessibilityAction (View.java:13037)
android.view.AccessibilityInteractionController.performAccessibilityActionUiThread (AccessibilityInteractionController.java:691)
android.view.AccessibilityInteractionController.access$500 (AccessibilityInteractionController.java:75)
android.view.AccessibilityInteractionController$PrivateHandler.handleMessage (AccessibilityInteractionController.java:1396)
android.os.Handler.dispatchMessage (Handler.java:107)
android.os.Looper.loop (Looper.java:230)
android.app.ActivityThread.main (ActivityThread.java:7815)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:526)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1034)

After taking a short time to review this bug, and this lib also. I found that: This crash occurred from wrong parameter, maybe came from Kotlin migration:

override fun performAccessibilityAction(host: View, action: Int, args: Bundle): Boolean {
}

It should be:

override fun performAccessibilityAction(host: View, action: Int, args: Bundle?): Boolean {
}

=> args: Bundle?: args is Nullable

I checked the current lib version, 2.0.0, and found that there is no changes/updates for this bug
Please take a look and fix it

Thank you very much,

@trietbui-zalora
Copy link

Hi @andrefrsousa Hope you can fix this issue after New Year holiday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants