Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

older rom is favored #30

Open
AlvaroBurnett opened this issue Nov 16, 2020 · 5 comments
Open

older rom is favored #30

AlvaroBurnett opened this issue Nov 16, 2020 · 5 comments

Comments

@AlvaroBurnett
Copy link

When processing Genesis roms, the generator thinks that:

Lost Vikings, The (USA) (November, 1993)

is better than:

Lost Vikings, The (USA) (October, 1995)

@andrebrait
Copy link
Owner

It currently doesn't have a distinction for dates. I can add it, though, as long as there's a formalized format for it.

@unexpectedpanda
Copy link

unexpectedpanda commented Nov 18, 2020

No-Intro is a bit inconsistent on dates. So far I've come across the following:

  • mm-dd-yyyy
  • mm-dd-yy
  • month name, yyyy

@andrebrait
Copy link
Owner

@unexpectedpanda username checks out :D

Yeah, I can introduce support for that. It's not that hard. Just a few more regexes and one term in the comparation tuple.

However, I think it should come after any sort of versioning, if one is present, so v2 is preferred over v1 February, which is preferred over v1 January, for example.

Does that make sense?

@unexpectedpanda
Copy link

Out of nowhere :P

Yep. Versions/revisions are much higher in my parent selection process than date, so makes sense to me :)

@andrebrait
Copy link
Owner

Ok, it's been a while but I'm finally gonna tackle this one this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants