Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAT lack SHA1digests #21

Open
majandres opened this issue Apr 22, 2020 · 6 comments
Open

DAT lack SHA1digests #21

majandres opened this issue Apr 22, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@majandres
Copy link

I'm using the FBneo dat (arcade only) file found here

and when I try to create a 1g1r set, I get this error:
ERROR: Cannot use hash information because DAT lacks SHA1 digests for [ym2608]

Looks like the DAT file only contains CRC and no SHA1 or MD5 hashes.

Is CRC usage enough? or will SHA1 be needed in the DAT files?

Thank you, this is a really great tool you built here.

@andrebrait
Copy link
Owner

I can potentially use CRC or even MD5, but these are less-than-ideal methods. Some major refactoring is in the works, so that might come :)

@majandres
Copy link
Author

appreciate the response. thank you.

@andrebrait andrebrait added the enhancement New feature or request label Jun 17, 2020
@prenetic
Copy link

A few of the No-Intro DATs include [MIA] entries which also fall into this category -- only CRC, no MD5 or SHA1. Would a viable option be to fall back to MD5 and ultimately CRC?. As it stands I've been adding a bogus SHA1 hash for dozens of these entries so the tool can function in scan mode with these DATs.

Example:
[MIA] Arkanoid + Rampage (Europe) (Summer Pack)

@andrebrait
Copy link
Owner

A few of the No-Intro DATs include [MIA] entries which also fall into this category -- only CRC, no MD5 or SHA1. Would a viable option be to fall back to MD5 and ultimately CRC?. As it stands I've been adding a bogus SHA1 hash for dozens of these entries so the tool can function in scan mode with these DATs.

Example:
[MIA] Arkanoid + Rampage (Europe) (Summer Pack)

Yeah, I started noticing these a while ago, but I'm not updating this tool anymore. There's one feature that I need to create a release for but I don't plan on refining it further.

I think https://github.com/andrebrait/DATROMTool already does this. It scans the files and adds filters them for SHA-1, MD5 and CRC+Size, in this order of priority.

I still have to finish a few things in there, but if you'd like you can grab the current pre-release build and give it a try and see if it works for your case

@prenetic
Copy link

Didn't realize there was a successor, I'll check that out as well -- thank you!

@andrebrait
Copy link
Owner

It isn't ready at the moment, but it's capable of doing everything this tool does, minus some occasional bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants