Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration guide: node 16 should be upgraded #1191

Open
okadurin opened this issue May 9, 2024 · 1 comment
Open

Migration guide: node 16 should be upgraded #1191

okadurin opened this issue May 9, 2024 · 1 comment
Labels
4.0 Planned for v4 major version documentation good first issue help wanted

Comments

@okadurin
Copy link

okadurin commented May 9, 2024

v3 was compatible with Node 16. And 4.0.0-prerelease.26 is not anymore. One of reasons is structuredClone which was introduced in Node 17.
The migration guide might mention the requirement for the Node upgrade.
@jorenbroekema
Copy link
Collaborator

https://github.com/amzn/style-dictionary/blob/v4/package.json#L35 it's in the engines field but I agree, would be great to mention in the migration guide! PR welcome -> https://github.com/amzn/style-dictionary/blob/v4/docs/src/content/docs/version-4/migration.md can be a section at the very top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 Planned for v4 major version documentation good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okadurin @jorenbroekema