Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some buildPath checks only consider / as a separator #1144

Open
jcfranco opened this issue Mar 29, 2024 · 0 comments
Open

Some buildPath checks only consider / as a separator #1144

jcfranco opened this issue Mar 29, 2024 · 0 comments
Labels
3.0 4.0 Planned for v4 major version bug

Comments

@jcfranco
Copy link

buildPath checks should use both Windows and POSIX separators, like buildFiles.js. Currently, cleanDirs and cleanFiles only check for /.
This was referenced Mar 29, 2024
Open
Merged
@jorenbroekema jorenbroekema added bug 3.0 4.0 Planned for v4 major version labels Mar 31, 2024
jcfranco added a commit to Esri/calcite-design-system that referenced this issue Apr 1, 2024
@jcfranco
build: fix design-tokens build in Windows (#9022)
82a43ba 
**Related Issue:** N/A

## Summary

This adds a workaround for
amzn/style-dictionary#1144.

**Note**: the workaround is only applied when the design token build
runs in Windows

Props to @josercarcamo for catching this and testing the workaround. ✨💪✨
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0 4.0 Planned for v4 major version bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfranco @jorenbroekema