Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose UI Multiplatform support #1111

Open
kirillzh opened this issue Feb 29, 2024 · 2 comments
Open

Compose UI Multiplatform support #1111

kirillzh opened this issue Feb 29, 2024 · 2 comments

Comments

@kirillzh
Copy link

Compose UI Multiplatform 1.6.0 added a common resources API to manage strings, fonts, drawables, etc: https://blog.jetbrains.com/kotlin/2024/02/compose-multiplatform-1-6-0-release/#common-resources-api.

It would be great if we could generate tokens in Compose UI Multiplatform using this new API.

@jorenbroekema
Copy link
Collaborator

jorenbroekema commented May 1, 2024

@nhoizey hey, would love to get your 2 cents on this, I know your current PR is related to XML outputs and this multiplatform format seems to be different, but perhaps we could start an initiative to add this to style-dictionary.

Let's start in a similar way to your PR: #1173, getting a bunch of design tokens of all types and creating a snapshot of what the desired output would look like, then we can start thinking of which transforms we'll need per token type and what the compose/multiplatform format would look like. Feel free to draft a PR, which can be similar to this #1173

@nhoizey
Copy link
Contributor

nhoizey commented May 1, 2024

It would be great to have larger support for different formats indeed.

Unfortunately, I'm not myself an Android developer, and the one I'm working with only using XML resource files, not Jetpack Compose at all, so I'm not sure I can help.

@kirillzh would you be able to create a PR similar to my #1173 but for Jetpack Compose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants