Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why HttpClient implementation is limited to use Curl? #81

Open
issei-m opened this issue Oct 4, 2019 · 2 comments
Open

Why HttpClient implementation is limited to use Curl? #81

issei-m opened this issue Oct 4, 2019 · 2 comments

Comments

@issei-m
Copy link

issei-m commented Oct 4, 2019

Nowadays, we have a variety of HTTP client implementations in the PHP world, and nothing seems to rely on the specific curl's feature found in HttpCurlInterface, so I suppose that we can simply have just an interface like HttpClientInterface instead of the curl-limited interface.

@bjguillot
Copy link
Contributor

Is the usage of Curl in current SDK causing an issue with your integration? Is it preventing you from using the HTTP client implementation of your choice in the rest of your code?

@issei-m
Copy link
Author

issei-m commented Oct 5, 2019

Actually, not yet.
But we sometimes need to use a web server that is limited of use where for example we cannot install PHP extension modules like curl anyway.
In such a case, it's more useful if it requires no extension module.
Also, that would match the policy only requiring PHP >=5.5 which came end-of-life in 2016 because on these servers I mentioned above, typically PHP version would possibly be older.

If this proposal would be legit, I'm willing to open a PullReq for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants