Ambiguous LoggerInterface #58
Comments
|
Seconded! |
ejegg
added a commit
to ejegg/login-and-pay-with-amazon-sdk-php
that referenced
this issue
Aug 10, 2017
This commit removes a duplicated version of Psr\Log, which could have caused applications to use a different version than expected. Instead, we list psr/log as a composer dependency. To facilitate unit tests, a phpunit-bootstrap file is added which includes vendor/autoload.php, and a phpunit.xml file is added to point to the bootstrap. Phpunit is also added to the require-dev section of composer.json, as the unit tests do depend on it. Fixes amzn#58
ejegg
added a commit
to ejegg/login-and-pay-with-amazon-sdk-php
that referenced
this issue
Aug 10, 2017
This commit removes a duplicated version of Psr\Log, which could have caused applications to use a different version than expected. Instead, we list psr/log as a composer dependency. To facilitate unit tests, a phpunit-bootstrap file is added which includes vendor/autoload.php, and a phpunit.xml file is added to point to the bootstrap. Running unit tests now requires 'composer install', but afterward you simply run 'phpunit' in the root directory of the project. 'composer test' also works. Phpunit is also added to the require-dev section of composer.json, as the unit tests do depend on it. Fixes amzn#58
ejegg
added a commit
to ejegg/login-and-pay-with-amazon-sdk-php
that referenced
this issue
Dec 15, 2017
This commit removes a duplicated version of Psr\Log, which could have caused applications to use a different version than expected. Instead, we list psr/log as a composer dependency. To facilitate unit tests, a phpunit-bootstrap file is added which includes vendor/autoload.php, and a phpunit.xml file is added to point to the bootstrap. Running unit tests now requires 'composer install', but afterward you simply run 'phpunit' in the root directory of the project. 'composer test' also works. Phpunit is also added to the require-dev section of composer.json, as the unit tests do depend on it. Fixes amzn#58
|
As mentioned in the existing PR i also appreciate this. |
|
I've come here to post this same comment. |
|
In 2023 the same problem |
|
i am facing same problem with laravel 10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The SDK ships it's own version of
Psr\Log\LoggerInterfacewhich causes some IDEs (like PHPStorm) to remark an ambiguity when composer is used to install the realPsr\Log\LoggerInterfacewhich is available twice then.Currently, I have to fork this SDK and remove the
Psr\Log\LoggerInterfaceto get rid of that remark.I see the following solution:
Psr\Log\LoggerInterfaceand also an default-adapter shipped with the SDK.Psr\Log\LoggerInterface-Files from the project and depend on composer alone. There is currently no implementation other thanNullLoggershipped with the SDK so the interface alone makes not much sense. The interface-typehint will work without the interface-files. Usinguseand typehinting don't require the actualinterfaceto be present.OR
/AmazonPayand/tst.The text was updated successfully, but these errors were encountered: