Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stellar_wind.py: wind incorrect for binaries #995

Open
rieder opened this issue Oct 6, 2023 · 0 comments
Open

stellar_wind.py: wind incorrect for binaries #995

rieder opened this issue Oct 6, 2023 · 0 comments
Labels

Comments

@rieder
Copy link
Member

rieder commented Oct 6, 2023

When using derive_from_evolution in stellar_wind.py in combination with a binary system, the resulting amount of wind particles is incorrect: it does not take the mass transfer to the companion into account, and therefore overestimates the wind.
To solve this, ideally one should have access to more properties of the stars than are available (to account for a potentially existing wind from the accretor) - but probably just subtracting the mass accreted by the other star would be good enough.
stellar_wind.py would then still have to know about binaries though - so an update is needed.

Alternatively, don't use derive_from_evolution with binary stars.

@rieder rieder added the bug label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant