Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimisation coded, but not used #23

Open
silviatoonen opened this issue Sep 11, 2023 · 5 comments
Open

optimisation coded, but not used #23

silviatoonen opened this issue Sep 11, 2023 · 5 comments
Assignees

Comments

@silviatoonen
Copy link
Collaborator

The Makefiles of SeBa include the optimisation flag -O through CFLAGS += -O
However CFLAGS is not used.

My suggestion: add a flag: CXXFLAGS += -O (or -O2)

Any objections of why not to do this?

@silviatoonen
Copy link
Collaborator Author

credit to Evert!

@silviatoonen
Copy link
Collaborator Author

from some preliminary tests, using the optimisation flags speeds up SeBa by a factor 2-3.

@rieder
Copy link
Member

rieder commented Sep 11, 2023 via email

@silviatoonen
Copy link
Collaborator Author

It would be for both.
It seems that this optimisation was intended to be included, but for some time it has not been the case.

@spzwart do you remember if for some reason it was switched of? otherwise I'll switch it back on. A factor 2-3 improvement is always nice.

@spzwart
Copy link
Contributor

spzwart commented Sep 14, 2023

Yes, I think that we had done problems with the convergence in teaching RLOF. but lets them out back on, and test the code, see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants