New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues in monero downloading code from README.md #16

Open

emanuelb opened this issue Jul 22, 2017 · 1 comment

emanuelb commented Jul 22, 2017

from README.md:

# Download latest Monero release
curl https://downloads.getmonero.org/cli/monero-linux-x64-v0.10.2.1.tar.bz2 > /tmp/monero.tar.bz2
# Validate file
echo "9edba6ca91c35c6c2eb6816f9342931c88648de5beb471943ea63d0b16c9a2e4 /tmp/monero.tar.bz2" | sha256sum -c
# Extract binanries
tar -xf /tmp/monero.tar.bz2 -C /tmp && mv /tmp/monero-v0.10.2.1/* /usr/local/bin/

use --location argument for curl instead of >
use enviroment variable to store version (such as '0.10.2.1') and use it instead of hardcoded value.
don't use static filename in /tmp , see: "Safely Creating Temporary Files in Shell Scripts"
http://www.linuxsecurity.com/content/view/115462/151/
use mktemp command instead for temp file/dir.
remove the archive file after extract operation.

The text was updated successfully, but these errors were encountered:

amiuhle mentioned this issue

Open

3 tasks

Owner

amiuhle commented Sep 17, 2017 •

edited

Thanks for the input!

use --location argument for curl instead of >

--location is to follow redirects, --output would be the correct option. What's the advantage over > though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment