Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Good time to apply this. #85

Open
manaspz opened this issue Aug 3, 2023 · 3 comments
Open

Good time to apply this. #85

manaspz opened this issue Aug 3, 2023 · 3 comments

Comments

@manaspz
Copy link
Contributor

manaspz commented Aug 3, 2023

          Thanks for the PR @Kolossi.

I would just suggest you move the logic to _includes/analytics.html file instead of creating a separate file. As I think, all the analytics code should live in a single file so it becomes more maintainable.

Thanks!

Originally posted by @amitmerchant1990 in #48 (comment)

@manaspz
Copy link
Contributor Author

manaspz commented Aug 3, 2023

Now that Google has dropped support for UA.
There is little to no requirement for the older analytics to exist.

Will generate a new PR for this soon.

@manaspz
Copy link
Contributor Author

manaspz commented Aug 3, 2023

Successfully implemented the same on: #86 (comment)

List of changes:

  • Removed older UA tag in config.yml
  • Added support documentation in project readme
  • Removed additional analytics_head.html and migrated GA4 support to analytics.html

@manaspz
Copy link
Contributor Author

manaspz commented Aug 5, 2023

@amitmerchant1990 Should I raise a PR ?
That will include the following changes :

  • Changing the config tag to GA4 (This would affect your analytics page, please check if your GA4 is valid)
  • Modifying the old analytics file to favor the new tag : analytics.html
  • Removing redundant code for the analytics_head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant