Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Autocomplete Suggestions Too Broad #47

Open
mikebronner opened this issue Mar 11, 2021 · 1 comment
Open

Enhancement Request: Autocomplete Suggestions Too Broad #47

mikebronner opened this issue Mar 11, 2021 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mikebronner
Copy link

I am seeing what I would call incorrect behavior, and am wondering if there are some settings I could implement to work around the problem. Consider the following example:

<?php

namespace Database\Factories;

use App\Models\Store;
use Illuminate\Database\Eloquent\Factories\Factory;

class StoreFactory extends Factory
{
    protected $model = Store::class;

    public function definition(): array
    {
        return [
            "address" => $this->faker->,
            "test1" => $this->faker->string,
            "test2" => $this->faker->string,
            "test3" => $this->faker->string,
            "test4" => $this->faker->string,
            "test5" => $this->faker->string,
            "test6" => $this->faker->string,
            "test7" => $this->faker->string,
        ];
    }
}

If you place your cursor at the end of the address field line, then delete the back to the greater-than, and re-type it to trigger auto-complete, it will suggest all keys listed in the array being returned. When autocompleting a variable, I would expect the autocomplete to only show items available in the variable.

@amir9480 amir9480 added bug Something isn't working help wanted Extra attention is needed labels Mar 12, 2021
@amir9480
Copy link
Owner

Hi @mikebronner

Extension parses code using regexes
and it's hard for me to fix bugs like this with regexes.
I try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants