Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using --prefer-offline for npm install is not best security practice #40

Closed
smackfu opened this issue May 11, 2023 · 1 comment 路 Fixed by #48
Closed

Using --prefer-offline for npm install is not best security practice #40

smackfu opened this issue May 11, 2023 · 1 comment 路 Fixed by #48
Labels
bug Something isn't working released

Comments

@smackfu
Copy link
Member

smackfu commented May 11, 2023

馃悶 Bug Report

Describe the bug

The npm install that is done in Step 5 uses the --prefer-offline flag to npm. While this is fast, it means your newly created project will have the same dependency versions as the last time you ran the generator, including any security issues. Best practice is to always use the current versions of packages when creating a new project. Otherwise you may start out with security vulnerabilities.

To Reproduce

Create a project using the template. The npm command will be run with --prefer-offline at the end.

Expected behavior

Either remove the flag or provide an option to not use it.

@oneamexbot
Copy link
Contributor

馃帀 This issue has been resolved in version 1.11.2 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
2 participants