Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of weights for un-weighted backends by controller #312

Open
CarltonSemple opened this issue Sep 29, 2016 · 3 comments
Open

Calculation of weights for un-weighted backends by controller #312

CarltonSemple opened this issue Sep 29, 2016 · 3 comments

Comments

@CarltonSemple
Copy link
Contributor

Calculating the weights for un-weighted backends by the controller would offload some of the work from the sidecar. This weight calculation could potentially be returned in the controller API as implicit_weight

@rshriram
Copy link
Member

rshriram commented Oct 3, 2016

I think we should avoid any more fields in the JSON schema, especially for things like this. Two options:

  1. We could actually replicate Nginx behavior and avoid the % based weights totally. In other words, you can specify any positive weight for a backend (100, 200, etc.). The controller can distribute the computed weights accordingly across the backends.
  2. We could stick with existing weights (0-1.0]. In this case as well, the controller computes the weights for unweighted backends before passing them on to the sidecar.

@frankbu
Copy link
Member

frankbu commented Oct 3, 2016

I prefer the second option. Note that this will be a breaking change from the existing GET implementation, but maybe that's not so bad.

@rshriram rshriram removed the sidecar label Oct 5, 2016
@rshriram
Copy link
Member

rshriram commented Dec 5, 2016

I think this has been handled in the recent changes to controller. @ijsnellf @GregHanson ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants