Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store a Redis hash per instance, rather than a marshaled JSON string #289

Open
zcahana opened this issue Sep 21, 2016 · 2 comments
Open

Comments

@zcahana
Copy link
Member

zcahana commented Sep 21, 2016

This has multiple advantages:

  • It enables faster heartbeat operations - no need to read-modify-write the whole instance data (as is today) - only need to read the status and TTL, and write the last_updated + EXPIRE.
  • It enables more efficient partial queries, especially when the instance metadata is large (e.g. GET /api/v1/instances?fields=service_name,endpoint,tags)
  • It's more extensible and flexible
@rshriram
Copy link
Member

rshriram commented Dec 5, 2016

Has this been resolved? @zcahana?

@zcahana
Copy link
Member Author

zcahana commented Dec 5, 2016

Nope, it hasn't been touched since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants