Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing empty email address validation #1341

Open
danacotoran opened this issue Dec 20, 2021 · 0 comments
Open

Missing empty email address validation #1341

danacotoran opened this issue Dec 20, 2021 · 0 comments
Labels

Comments

@danacotoran
Copy link
Contributor

danacotoran commented Dec 20, 2021

When a user clicks the 'No' button on "Is this page useful?" they get an offer to be emailed a link to the survey.

Screenshot 2021-11-26 at 11 01 14

But if they leave the 'Email address' field empty and click the green 'Send me the survey' button, they don't get an error/hint, just a Thank you message.

Screenshot 2021-11-26 at 11 02 36

On the frontend, the feedback component displays a success message only if status code 200 is returned, which seems to be what is happening when an empty email field is submitted. When server side validation for email address has failed, the response status code should probably be a 400 with an error message attached.


Zendesk ticket where this was reported originally https://govuk.zendesk.com/agent/tickets/4786005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant