Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract pre_render_block logic #64

Closed
mogmarsh opened this issue Mar 28, 2024 · 0 comments · Fixed by #78
Closed

extract pre_render_block logic #64

mogmarsh opened this issue Mar 28, 2024 · 0 comments · Fixed by #78
Assignees
@anubisthejackle
Labels
enhancement New feature or request php Requires understanding PHP

Comments

@mogmarsh
Copy link
Collaborator

Description

the pre_render_block filter on both the is-false and is-true block both use very similar logic. If that logic will be used elsewhere as well, or even pieces of it, it may be useful to extract that logic out into reusable functions.

Use Case

DRY up the code
@mogmarsh mogmarsh added the enhancement New feature or request label Mar 28, 2024
@anubisthejackle anubisthejackle self-assigned this Apr 29, 2024
@anubisthejackle anubisthejackle mentioned this issue Apr 29, 2024
Merged
5 tasks
@kevinfodness kevinfodness added the php Requires understanding PHP label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anubisthejackle anubisthejackle

Labels
enhancement New feature or request php Requires understanding PHP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue-64: extract pre_render_block logic alleyinteractive/wp-conditional-blocks
3 participants
@anubisthejackle @kevinfodness @mogmarsh