Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fairscale::with_wrapped_modules logic to a separate argument in the trainer #270

Open
AkshitaB opened this issue Apr 15, 2022 · 0 comments · May be fixed by #271
Open

Move fairscale::with_wrapped_modules logic to a separate argument in the trainer #270

AkshitaB opened this issue Apr 15, 2022 · 0 comments · May be fixed by #271

Comments

@AkshitaB
Copy link
Contributor

Rather than wrapping the model before passing it to the trainer. We want to do this because the checkpoint_wrapper in with_wrapped_modules creates a weakref for the wrapped modules, rendering the model unpicklable.
@AkshitaB AkshitaB added good first issue Good for newcomers and removed good first issue Good for newcomers labels Apr 15, 2022
This was referenced Apr 15, 2022
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Module wrapper allenai/tango
1 participant
@AkshitaB