bon eval #111
Open
bon eval #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will give a more thorough review once the data is moved. |
natolambert
requested changes
Apr 25, 2024
There was a problem hiding this comment.
This is getting closer. High level comments also shared on slack.
- We still have more jsons to move to huggingface
- Make all of this happen in the existing
scripts/run_bon.py. - To do so, most of the functions can be in
rewardbench/bon_utils.py - We can have duplicated scripts in analysis in case there's an error and someone wants to re-run alpacaeval conversion
- Code cleaning, adding license, removing unnecessary things
Mostly, I want to make this first-party supported in the repo, not a separate folder.
natolambert
reviewed
Apr 25, 2024
| @@ -0,0 +1,2 @@ | |||
| bon_data/ | |||
There was a problem hiding this comment.
Do we need these? Can we just change filepaths to align with existing scripts? Not sure they need to be different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.