Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to log metrics regardless of train/val/test #292

Open
qiwu57kevin opened this issue Jun 10, 2021 · 2 comments
Open

Enable to log metrics regardless of train/val/test #292

qiwu57kevin opened this issue Jun 10, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@qiwu57kevin
Copy link

Problem

I would like to log metrics in a document during training and validation as what you have done for testing. Currently I have to open tensorbard and get

Desired solution

Is it possible to use a flag, like the tensorboard logging, to enable or disable metric logging regardless of stages?

@qiwu57kevin qiwu57kevin added the enhancement New feature or request label Jun 10, 2021
@Lucaweihs
Copy link
Collaborator

Hi @KevinWu57,

PR #253 actually introduces an update to allow for saving validation metrics via a --collect_valid_results flag, this should be merged in the next few days (I just need to find time for a final review) but you should be able to install this version of AllenAct ahead of time if you'd like:

pip install -e "git+https://github.com/allenai/allenact.git@b6c4a2f7ae1759c3e40eb0b849f9778093b79ddc#egg=allenact&subdirectory=allenact"
pip install -e "git+https://github.com/allenai/allenact.git@b6c4a2f7ae1759c3e40eb0b849f9778093b79ddc#egg=allenact_plugins&subdirectory=allenact_plugins"

Saving the training metrics to a metric file is something we hadn't thought of so might take some more effort. Note that you can always run testing but update the relevant experiment config file to use training dataset instead of the test dataset as a temporary workaround. If we built a function that let you extract the training metrics from the tensorboard file, would that be sufficient for you? I.e. are you just looking for a way to get these metrics without having to run tensorboard explicitly?

@Lucaweihs Lucaweihs self-assigned this Jun 10, 2021
@qiwu57kevin
Copy link
Author

Hi @Lucaweihs ,

Thanks for your response! Yes, I think a function that can extract the training metrics from the tensorboard file would be good for me so that I don't have to run tensorboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants