Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VizSuite breaks with length-1 episodes, does not support arbitrary action spaces/distributions #255

Open
jordis-ai2 opened this issue Feb 26, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jordis-ai2
Copy link
Collaborator

jordis-ai2 commented Feb 26, 2021

Problem

Some visualization types assume episode lengths > 1. VizSuite further assumes action spaces are Discrete(n).

Steps to reproduce

Modify projects/tutorials/running_inference_tutorial.py with:

    def machine_params(self, mode="train", **kwargs):
        res = super().machine_params(mode, **kwargs)
        if mode in ["test", "valid"]:
            res.set_visualizer(self.get_viz(mode))

        return res

    @classmethod
    def training_pipeline(cls, **kwargs):
        pipeline = super().training_pipeline(**kwargs)
        pipeline.save_interval = 1
        return pipeline

Then run training with
python main.py projects/tutorials/running_inference_tutorial.py -o debug_valid_viz -l debug

@jordis-ai2 jordis-ai2 added the bug Something isn't working label Feb 26, 2021
@jordis-ai2 jordis-ai2 self-assigned this Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant