Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringFilterClause and ignoreCase #1033

Open
4 tasks
adrianmroz-allegro opened this issue Feb 10, 2023 · 0 comments
Open
4 tasks

StringFilterClause and ignoreCase #1033

adrianmroz-allegro opened this issue Feb 10, 2023 · 0 comments

Comments

@adrianmroz-allegro
Copy link
Contributor

After #1032, StringFilterClause has option ignoreCase that makes sense only for filters in CONTAINS mode. Rest of available modes ignore this setting.

Because we don't want to create new ViewDefinition version, we should leave FilterClauseDefinition objects in place. New field is optional with default value false. That's cool.

  • We should create three new FilterClause classes for each string filter mode. Jest like with TimeFilterClause.
  • Converters should handle validation and creation of specific class
  • Fix all call sites for StringFilterClause - it will be only a Type, not a real class
  • Add TypeGuard(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant