Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Added TLS support configuration #23

Open
Liron24 opened this issue Nov 7, 2018 · 7 comments
Open

Added TLS support configuration #23

Liron24 opened this issue Nov 7, 2018 · 7 comments

Comments

@Liron24
Copy link

Liron24 commented Nov 7, 2018

Hi alicebob,
I have added a TLS support to the tool.
I changed the flags a bit and basically added an option to choose either secure connection or not.
Would love to contribute back, wdyt?

@alicebob
Copy link
Owner

alicebob commented Nov 8, 2018

Sounds good! Could you open a PR, @Liron24 ?

@Liron24
Copy link
Author

Liron24 commented Nov 29, 2018

Hi, seems that I don't have permissions to create new branch, can you grant me? Or do you prefer do it some other way?

@alicebob
Copy link
Owner

Hi @Liron24. You would make a fork of this repository (there is a button above somewhere). That gives you a copy in github.com/Liron24/asprom, which you can use to make your changes. When that's done you open a Pull Request in there, and it should show up here.
Let me know if I can help you with anything. There is also https://help.github.com/articles/fork-a-repo/ which might give you more details.

@Liron24
Copy link
Author

Liron24 commented Nov 30, 2018

Done :) Thank you.

@Asisranjan
Copy link

Hi @Liron24 and @alicebob
Which version does it support tls

@MicahCarrick
Copy link

@Asisranjan I didn't see it get merged in. @Alb0t are you running the TLS fork?

@Alb0t
Copy link
Contributor

Alb0t commented Dec 11, 2019

Negative @MicahCarrick

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants